[
https://issues.apache.org/jira/browse/CLI-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Yandell closed CLI-149.
-----------------------------
Resolution: Fixed
svn ci -m "Adding comma delimited whitespace to the exception message that
lists missing required options as requested in CLI-149. I didn't add the
requested -, as it could be -- or some other prefix. Unit tests also added. "
Sending src/java/org/apache/commons/cli/Parser.java
Sending src/test/org/apache/commons/cli/OptionsTest.java
Sending src/test/org/apache/commons/cli/ParseRequiredTest.java
Transmitting file data ...
Committed revision 654431.
> MissingOptionException.getMessage() changed from CLI 1.0 > 1.1
> --------------------------------------------------------------
>
> Key: CLI-149
> URL: https://issues.apache.org/jira/browse/CLI-149
> Project: Commons CLI
> Issue Type: Bug
> Components: CLI-1.x
> Affects Versions: 1.1
> Reporter: Nathan Niesen
> Fix For: 1.2
>
>
> The MissingOptionException.getMessage() string changed from CLI 1.0 > 1.1.
> CLI 1.0 was poorly formatted but readable:
> Missing required options: -format-source-properties
> CLI 1.1 is almost unreadable:
> Missing required options: formatsourceproperties
> In CLI 1.0 Options.addOption(Option) prefixed the stored options with a "-"
> and in CLI 1.1 it doesn't.
> I would suggest changing Parser.checkRequiredOptions() to add the options to
> the error message with a prefix of " -":
> OLD:
> // loop through the required options
> while (iter.hasNext())
> {
> buff.append(iter.next());
> }
> NEW:
> // loop through the required options
> while (iter.hasNext())
> {
> buff.append(" -" + iter.next());
> }
> Resulting in:
> Missing required options: -format -source -properties
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
