[ 
https://issues.apache.org/jira/browse/IO-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599676#action_12599676
 ] 

Sebb commented on IO-167:
-------------------------

It looks odd that the patch for convertCase() upcases and then downcases the 
characters.
Might be an idea to add a comment to the patch explaining that this is 
necessary to agree with String.equalsIgnoreCase().

I agree that that FileSystemUtils needs to use Locale.ENGLISH for OS name 
comparisons.

As to whether wildcardMatch() should be platform-dependent or independent, 
there are probably use-cases for both.
But whatever is decided - maybe have two versions? - the Javadoc needs to make 
it clear (and it needs to work in Turkey!)


> Fix case-insensitive string handling
> ------------------------------------
>
>                 Key: IO-167
>                 URL: https://issues.apache.org/jira/browse/IO-167
>             Project: Commons IO
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Benjamin Bentmann
>         Attachments: IO-167-a.patch, IO-167.patch, IO-167.patch
>
>
> Case-insensitive operations are currently platform-dependent, please see 
> [Common Bug #3|http://www.nabble.com/Re%3A-Common-Bugs-p14931921s177.html] 
> for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to