[ 
https://issues.apache.org/jira/browse/CODEC-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb updated CODEC-72:
----------------------

    Attachment: soundex.patch

Make char arrays private; use array copy of char[] parameters.
Add public string to RefinedSoundex to give access to mapping.

Add constructors which take a string.

Update test cases to test other constructors.

> Soundex and RefinedSoundex issues with character arrays
> -------------------------------------------------------
>
>                 Key: CODEC-72
>                 URL: https://issues.apache.org/jira/browse/CODEC-72
>             Project: Commons Codec
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>         Attachments: soundex.patch
>
>
> Soundex and RefinedSoundex both have public US_ENGLISH_MAPPING char arrays. 
> These don't appear to be used externally, so should be made private - or at 
> least package protected.
> Also, the class constructors store externally mutable char arrays; it would 
> be better if these were copied.
> Patch to follow.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to