[
https://issues.apache.org/jira/browse/COLLECTIONS-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628816#action_12628816
]
Nathan Bubna commented on COLLECTIONS-271:
------------------------------------------
I think your patch for this breaks getKeys() after a combine() call. It
appears to make combine() not track new keys, which breaks both getKeys() and
subset(). Because combine() then subset() is broken, Velocity has been
experiencing frustratingly mysterious failures for months now. For more on the
symptoms, see:
http://tinyurl.com/5hjxrq
I suspect instead of super.put(), the patch for this should have used
clearProperty() followed by addPropertyDirect(). Of course, i haven't tested
that...
> org.apache.commons.collections.ExtendedProperties#combine don't import string
> properly
> --------------------------------------------------------------------------------------
>
> Key: COLLECTIONS-271
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-271
> Project: Commons Collections
> Issue Type: Bug
> Components: Collection
> Affects Versions: 3.2
> Reporter: Alexander Borovsky
> Fix For: 3.3
>
> Attachments: COLLECTIONS-271.patch, fix.patch
>
>
> When we set property with escaped characters, after combine propertySets we
> got them unescaped.
> Simple Example
> ExtendedProperties props = new ExtendedProperties();
> props.setProperty("test", "\\\\\\\\192.168.1.91\\\\test");
> props.getProperty("test"); // => \\192.168.1.91\test
> ExtendedProperties props2 = new ExtendedProperties();
> props2.combine(props);
> props.getProperty("test"); // => \192.168.1.91\test -- Wrong!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
