[
https://issues.apache.org/jira/browse/CONFIGURATION-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636688#action_12636688
]
Oliver Heger commented on CONFIGURATION-337:
--------------------------------------------
Ralph,
many thanks for your contribution. I had a look at the patch, and this is
really some cool stuff. I am happy to apply it, but have the following minor
suggestions:
* So far the providers' classes are directly loaded, and instances are created
through reflection. Why not reusing our bean declaration mechanism for this
purpose? This would also allow setting properties on the provider objects
created.
* I would prefer if {{ExtendedCombinedConfiguration}}, which is used for
testing the config-class attribute for the resulting configuration, was an
inner class of TestDefaultConfigurationBuilder. It is only used in this test
class and does not deserve the status of a top level class.
What do you think?
> Allow users of DefaultConfigurationBuilder to configure the class name of
> the CombinedConfiguration to create and to configure providers
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CONFIGURATION-337
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-337
> Project: Commons Configuration
> Issue Type: Improvement
> Affects Versions: 1.6
> Environment: Any
> Reporter: Ralph Goers
> Fix For: 1.6
>
> Attachments: config.patch
>
>
> This enhancement allows config-class to be specified on the result element.
> The specified class must extend CombinedConfiguration.
> This enhancment allows ConfigurationProviders to be configured by adding
> <providers>
> <provider tag="myprovider" config-class="MyProviderClass"/>
> </providers
> to the header.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
