Method createServerSocket of FTPSSocketFactory will never be called and thus 
UseClientMode is incorrect in a secured ftp transfer using active mode. 
-----------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: NET-242
                 URL: https://issues.apache.org/jira/browse/NET-242
             Project: Commons Net
          Issue Type: Bug
            Reporter: David Latorre
            Priority: Minor


When the data channel is secured and we are using Active mode , we need to set 
UseClientMode to true in the FTP Client so even though the FtpServer is 
initiating the connection, he is the "server" in the SSL handshake.

In the current code , this is done in the method init() called by 
createServerSocket() in FTPSSocketFactory. But this method is never called as 
we create ServerSockets using a ServerSocketFactory.  

The solution is to create a FTPSServerSocketFactory which takes the 
responsibility of creating ServerSockets.  

Fix provided.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to