[
https://issues.apache.org/jira/browse/SCXML-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649709#action_12649709
]
Ingmar Kliche commented on SCXML-90:
------------------------------------
I checked out the fix and run the test cases and it worked for me.
The only question I have: You check whether "event" evaluates to an empty
"eventValue":
if (SCXMLHelper.isStringEmpty(eventValue)
&& appLog.isWarnEnabled()) {
appLog.warn("<send>: event expression \"" + event
+ "\" evaluated to null or empty String");
to log a warning message in this case. Because of a logging a "warning", this
case seems to be close to an error (at least when reading the log). But there
are certainly valid usecases where the eventname is meaningless, e.g. an HTTP
request:
<send target="URL" targettype="basichttp" namelist="some params"/>
In this case the implementation would log a warning. Should an empty eventname
be a "info" or "debug" message instead? But this is just a minor comment.
Thanks!
> event attribute of <send> is not evaluated
> ------------------------------------------
>
> Key: SCXML-90
> URL: https://issues.apache.org/jira/browse/SCXML-90
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Ingmar Kliche
> Fix For: 0.9
>
>
> The "event"-Attribute of <send> is not evaluated. This is not in line with
> the SCXML WD.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
