[ 
https://issues.apache.org/jira/browse/FILEUPLOAD-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ignacio Coloma closed FILEUPLOAD-161.
-------------------------------------

    Resolution: Invalid

After further testing, the standard says that ISO-8859-1 is the default charset 
but also that the browser should use the same encoding of the last response 
received, which is what's happening. This is error prone, as the default 
charset used by the browser will be different upon this being the first request 
or not.

Supposing a default ISO8859-1 is as wrong as using UTF-8. Instead, it's easier 
to set the default response encoding to UTF-8 (which is the official 
recommendation of the w3c, anyways), and by doing that the current 
implementation would be doing the right thing (parsing any other request as 
UTF-8).

I'm marking the patch as INVALID.

> Default headerEncoding should be ISO-8859-1
> -------------------------------------------
>
>                 Key: FILEUPLOAD-161
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-161
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.2.1
>            Reporter: Ignacio Coloma
>         Attachments: patch.txt
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> When the browser does not include an encoding, commons-fileupload is using 
> the system default, but the standard says that it should be using ISO-8859-1:
> https://bugzilla.mozilla.org/show_bug.cgi?id=241540
> The link includes links to the corresponding sections of the RFC. This issue 
> is related to FILEUPLOAD-56 and FILEUPLOAD-100.
> To reproduce this bug, try to upload a file including special characters from 
> a ISO-8859-1 browser (firefox or explorer on windows) to a UTF-8 server with 
> tomcat. The file contents arrive fine, but any special characters in the 
> filename get lost. 
> A patch follows.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to