[
https://issues.apache.org/jira/browse/SANDBOX-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Akolkar resolved SANDBOX-271.
-----------------------------------
Resolution: Fixed
Thanks, applied in r727525:
http://svn.apache.org/viewvc?view=rev&revision=727525
For me (JDK 1.6), a couple of tests were failing before the patch (related to
Thread.yield() ) and now pass.
There was some issue with the pom.xml changes in the patch, I had to manually
fold the change in. Please generate patches against clean and latest versions
of the trunk, thanks.
> Synchronization and serialization changes from Kris
> ---------------------------------------------------
>
> Key: SANDBOX-271
> URL: https://issues.apache.org/jira/browse/SANDBOX-271
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: Pipeline
> Reporter: Ken Tanaka
> Attachments: kn_sync.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Kris Nuttycomb sent me some changes a while ago to enhance synchronization
> and add serialVersionUID keys to some events and exceptions. These changes
> haven't made it into the code base, so here they are for review (a patch file
> will be attached). The first and last changes listed below were originated by
> me.
> Here is a summary of the changes:
> change pom.xml
> * change junit version from 3.8.1 to 4.5, this is a change I made, since the
> Netbeans IDE can generate test code for this version. Some annotations were
> added because of this.
> change src/test/java/org/apache/commons/pipeline/PipelineTest.java
> * replace {{Thread.yield()}} with {{synchronized(counter)}}
> add a {{serialVersionUID}} to
> * src/main/java/org/apache/commons/pipeline/event/ObjectProcessedEvent.java
> * src/main/java/org/apache/commons/pipeline/event/PipelineShutdownRequest.java
> * src/main/java/org/apache/commons/pipeline/event/KeyAvailableEvent.java
> * src/main/java/org/apache/commons/pipeline/PipelineCreationException.java
> *
> src/main/java/org/apache/commons/pipeline/validation/ValidationException.java
> * src/main/java/org/apache/commons/pipeline/StageException.java
> change
> src/main/java/org/apache/commons/pipeline/listener/ObjectProcessedEventCounter.java
> * make the getCounts() method {{synchronized}}
> change src/main/java/org/apache/commons/pipeline/testFramework/TestStage.java
> * change the processedObjects list into a {{Collections.synchronizedList(new
> ArrayList<Object>())}}
> change
> src/main/java/org/apache/commons/pipeline/testFramework/TestStageContext.java
> * change the listeners list into a {{Collections.synchronizedList( new
> ArrayList<StageEventListener>() )}}
> * notify listeners when an event is raised
> change src/main/java/org/apache/commons/pipeline/config/PipelineRuleSet.java
> * Some minor javadoc formatting improvements
> * Noted that <feed> configuration information must follow the first stage,
> otherwise it will have no effect
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
