[
https://issues.apache.org/jira/browse/SCXML-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Akolkar updated SCXML-103:
--------------------------------
Fix Version/s: 1.0
0.10
Any such instances clearly need improvement. The example above does indeed
throw an Error (it was a strange API choice IMO, but it is what it is) so that
will need to be caught as well.
Setting fix version to next releases out of trunk and J6 branch.
> ThreadDeath should not be ignored
> ---------------------------------
>
> Key: SCXML-103
> URL: https://issues.apache.org/jira/browse/SCXML-103
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 0.10, 1.0
>
>
> There are a few instances where the code catches Throwable, but fails to
> rethrow anything.
> For example:
> {code}
> org.apache.commons.scxml.io.SCXMLSerializer.getTransformer()
> ...
> } catch (Throwable t) {
> return null;
> }
> {code}
> It would be safer if the code only caught the relevant Exception(s) (and
> perhaps some Errors).
> For example does it really make sense to catch OutOfMemory ?
> In particular, the Javadoc for ThreadDeath says:
> {quote} If ThreadDeath is caught by a method, it is important that it be
> rethrown so that the thread actually dies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
