inefficiencies identified by findbugs
-------------------------------------
Key: EXEC-35
URL: https://issues.apache.org/jira/browse/EXEC-35
Project: Commons Exec
Issue Type: Bug
Affects Versions: 1.0
Environment: linux
Reporter: Luc Maisonobe
Priority: Trivial
Attachments: findbugs-fixes.patch
I've run findbugs, it shows the following issues:
DefaultExecutor (line 203)
setExitValues(int[]) may expose internal representation by storing an
externally mutable object into DefaultExecutor.exitValues
DefaultProcessingEnvironment (lines 169 and 171)
Hard coded reference to an absolute pathname
DefaultProcessingEnvironment (line 108) and
OpenVmsProcessingEnvironment (line 89)
concatenates strings using + in a loop
OpenVmsProcessingEnvironment (line 114) and
MapUtils (line 72)
inefficient use of keySet iterator instead of entrySet iterator
The first issue should probably be fixed by cloning the array, but does
not appear to be an important problem. The second issue is a false
positive (if findbugs were activated by default in the pom, this could
be prevented by a configured exclusion file). The remaining issues are
harmless.
I will provide a patch to fix these issues shortly
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
