SequencedHashMap constructor calls overridable method; throws Error
-------------------------------------------------------------------

                 Key: DBCP-280
                 URL: https://issues.apache.org/jira/browse/DBCP-280
             Project: Commons Dbcp
          Issue Type: Bug
            Reporter: Sebb


The constructor SequencedHashMap(Map) calls the public non-final method 
putAll().

This is likely to cause problems if the class is ever extended. Possible 
solution: extract the code into a common private method.

The next() method also throws an Error if the return type is unexpected.
It should probably return IllegalStateException or similar.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to