[
https://issues.apache.org/jira/browse/COLLECTIONS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673933#action_12673933
]
Matt Benson commented on COLLECTIONS-317:
-----------------------------------------
Another, albeit somewhat--different, option would be to expose the
implementation detail of putAll() being called in the javadoc specification of
the method. Then a subclass implementor could simply choose to call a
different super constructor if appropriate.
> AbstractHashedMap(Map map) constructor calls overridable non-final method
> -------------------------------------------------------------------------
>
> Key: COLLECTIONS-317
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-317
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
> Reporter: Sebb
> Priority: Minor
>
> The constructor AbstractHashedMap(Map map) calls the public non-final method
> putAll() from the same class.
> This is likely to cause problems if the method is ever overridden, as the
> parent may not have been completely initialised when the sub-class method is
> invoked.
> Possible solution: extract the code into a common private method. Or make the
> method final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
