[
https://issues.apache.org/jira/browse/SANDBOX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Grobmeier updated SANDBOX-299:
----------------------------------------
Attachment: patch-exceptionhandlinginfactories.txt
The attached patch fixes the following:
- ArchiveStreamFactory and CompressStreamFactory throw an Exception now if no
fitting Archiver/Compressor cand be found
- If the name of the impl. or the stream is null, an IllegalArgumentException
will be thrown
- ArchiverStreamFactory.createArchiveInputStream(final InputStream in) doesn't
throw in IOException anymore (will be wrapped around ArchiveException, like
Compressor-Factory does)
- ArchiverStreamFactory.createArchiveInputStream(final InputStream in) now
checks if the incoming stream is true at markSupported(). If no, an
IllegalArgumentException will be thrown. I also removed the TODO on that place.
> ArchiveStreamFactory.createArchiveInputStream() & createArchiveOutputStream()
> should throw Exception if archiverName is not recognised
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SANDBOX-299
> URL: https://issues.apache.org/jira/browse/SANDBOX-299
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Compress
> Reporter: Sebb
> Priority: Minor
> Attachments: patch-exceptionhandlinginfactories.txt
>
>
> ArchiveStreamFactory.createArchiveInputStream() should throw an Exception if
> archiverName is not recognised - at present it returns null, which is not
> particularly helpful.
> The method sig says it throws ArchiveException; however it could also throw
> IllegalArgumentException.
> Likewise for createArchiveOutputStream()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
