[ 
https://issues.apache.org/jira/browse/POOL-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Thomas resolved POOL-133.
------------------------------

    Resolution: Fixed

Fixed in r755401

> Failed object creation may result in invalid active count in GKOP
> -----------------------------------------------------------------
>
>                 Key: POOL-133
>                 URL: https://issues.apache.org/jira/browse/POOL-133
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Mark Thomas
>            Assignee: Mark Thomas
>             Fix For: 1.5
>
>
> In GenericKeyedObjectPool.borrowObject() there are two instances of:
>                 try {
>                     _factory.destroyObject(key,pair.value);
>                     synchronized (this) {
>                         pool.decrementActiveCount();
>                     }
>                 } catch (Exception e2) {
>                     // swallowed
>                 }
> The decrementing of the active count should be moved to a finally block to 
> ensure that it is always called even if destroyObject() throws an exception.
> I think this is what DCP-34 is getting at.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to