[ 
https://issues.apache.org/jira/browse/DBCP-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688101#action_12688101
 ] 

Phil Steitz commented on DBCP-199:
----------------------------------

The first statement in the issue report is incorrect.  Each time any of the 
createStatement(...), prepareStatement(...), or prepareCall(...) methods are 
invoked, the last used property of the parent connection is updated by the 
DelegatingStatement constructor.  I am inclined to close this, therefore, as 
invalid.  The remaining cases to consider are other methods of 
DelegatingConnection and DelegatingStatement methods (which do not update last 
used of either the statement or its parent).  

> The last used time in AbandonedTrace should be updated more frequently.
> -----------------------------------------------------------------------
>
>                 Key: DBCP-199
>                 URL: https://issues.apache.org/jira/browse/DBCP-199
>             Project: Commons Dbcp
>          Issue Type: Improvement
>    Affects Versions: 1.2.1
>            Reporter: Kevin Ruland
>            Priority: Minor
>             Fix For: 1.3
>
>
> The current implementation of DelegatingConnection only updates the last used 
> timestamp in the AbandonedTrace base class when the connection is activated.  
> This can cause the abandoned connection logic to fail if a connection is 
> created and held onto for a long time.  I suggest the 
> abandondedTrace.setLastUsed() method be called from various methods in 
> DelegatingConnection to refresh this time.  An incomplete list of methods 
> would include those that create and prepare statements and execute sql.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to