[ 
https://issues.apache.org/jira/browse/COMPRESS-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694048#action_12694048
 ] 

Sebb commented on COMPRESS-64:
------------------------------

I now think that the finish method may be useful for some archive types which 
allow arbitrary data to be added at the end of the archive.

However, I think the method should throw an Exception if the user tries to call 
it twice.

> Are the public finish() methods ArchiveOutputStream implementations necessary 
> and safe?
> ---------------------------------------------------------------------------------------
>
>                 Key: COMPRESS-64
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-64
>             Project: Commons Compress
>          Issue Type: Bug
>            Reporter: Sebb
>
> Some of the ArchiveOutputStream implementations have public finish() methods. 
> These are currently only called from the close() methods.
> Seems to me that there is no need to allow the finish() methods to be called 
> externally, and the user can corrupt the output if they do.
> Surely the close() method is all that is needed?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to