[ 
https://issues.apache.org/jira/browse/COMPRESS-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698378#action_12698378
 ] 

Christian Grobmeier commented on COMPRESS-69:
---------------------------------------------

I improved the testcase where the described behaviour can be seen. I also think 
BZ should be added at the OutputStream.
Thanks for reporting!

> Inconsistent handling of BZ2-Header after redesign
> --------------------------------------------------
>
>                 Key: COMPRESS-69
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-69
>             Project: Commons Compress
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Uwe Schindler
>
> I tried the current trunk of compress and tried the BZIP2-Streams. There are 
> the following inconsitenceis now:
> a) BZIP InputStream checks that the "BZ" header is available in the File 
> (using this magicChar method)
> b) BZIP OutputStream does not add the "BZ" header (it is commented out, 
> saying that the caller does this)
> c) The Javadocs of the input stream say, you should skip the header, which is 
> wrong.
> d) the tests do not find these errors, as the test only compressed a file, 
> but does not try to decompress it or check its contents
> Before the redesign commit, the handling of headers was consistent (both 
> streams used it). The BZ Headers should be added to the Streams, as this 
> would be consistent with GZIP (where the headers are automatically added, 
> too).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to