Improve thread-safety of ExtendedProperties
-------------------------------------------
Key: COLLECTIONS-325
URL: https://issues.apache.org/jira/browse/COLLECTIONS-325
Project: Commons Collections
Issue Type: Improvement
Reporter: Sebb
It looks as though ExtendedProperties is intended to be thread-safe, otherwise
why bother synchronizing load() and save()?
If so, then ExtendedProperties field "isInitialized" should be made volatile to
ensure the variable is correctly published.
Likewise, the field "includePropertyName" needs to be volatile or synchronised.
Also, the following protected variables could be made final to improve
thread-safety:
defaults
file
basePath
fileSeparator - this could perhaps be static too?
keysAsListed
Regardless of thread-safety issues, does it make sense for these variables to
be changed once initialised?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
