[ 
https://issues.apache.org/jira/browse/IO-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremias Maerki updated IO-206:
-------------------------------

    Attachment: IO-206-ProxyInputStream-Param-Fix.diff

For some reason, I can't currently commit to IO trunk. Attaching the patch.

> ProxyInputStream: misleading parameter names
> --------------------------------------------
>
>                 Key: IO-206
>                 URL: https://issues.apache.org/jira/browse/IO-206
>             Project: Commons IO
>          Issue Type: Bug
>          Components: Streams/Writers
>    Affects Versions: 2.0
>            Reporter: Jeremias Maerki
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: IO-206-ProxyInputStream-Param-Fix.diff
>
>
> ProxyInputStream has a the following method signatures:
> - public int read(byte[] bts, int st, int end)
> - public void mark(int idx)
> But they should be:
> - public int read(byte[] bts, int off, int length)
> - public void mark(int readlimit)
> Especially the "end" parameter could be misinterpreted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to