[ 
https://issues.apache.org/jira/browse/POOL-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710501#action_12710501
 ] 

Sebb commented on POOL-137:
---------------------------

Re: _whenExhaustedAction : this should be documented for later maintainers 
please.

Access to Latch fields need to be synch. regardless of whether the access is 
simultaneous or not - if one thread sets a field, another thread may not see 
the same value in the absence of synch.

Re: Config - I thought the fields were used as constants, but on looking again 
they are used as defaults - so please ignore that comment.

> Inconsistent synchronization in GenericObjectPool; constant fields should be 
> final
> ----------------------------------------------------------------------------------
>
>                 Key: POOL-137
>                 URL: https://issues.apache.org/jira/browse/POOL-137
>             Project: Commons Pool
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 1.5
>
>
> _whenExhaustedAction is not always accessed using synchronization.
> The private static Latch class appears to be used across threads, but has no 
> synchronization.
> The static class Config contains several fields which appear to be used as 
> constants, however the fields are not final.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to