[ 
https://issues.apache.org/jira/browse/LANG-505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722981#action_12722981
 ] 

Henri Yandell commented on LANG-505:
------------------------------------

Committed as r787560. Leaving this issue open so people can beat me up about it 
:)

> Rewrite StringEscapeUtils
> -------------------------
>
>                 Key: LANG-505
>                 URL: https://issues.apache.org/jira/browse/LANG-505
>             Project: Commons Lang
>          Issue Type: Task
>            Reporter: Henri Yandell
>             Fix For: 3.0
>
>         Attachments: LANG-505.diff, LANG-505.diff
>
>
> I think StringEscapeUtils needs a strong rewrite. For each escape method (and 
> unescape) there tend to be three or four types of escaping happening. So not 
> being able to define which set of three or four apply is a pain point (and 
> cause of bug reports due to different desired features).
> We should be offering basic functionality, but also allowing people to say 
> "escape(Escapers.BASIC_XML, Escapers.LOW_UNICODE, Escapers.HIGH_UNICODE)".
> Also should delete escapeSql; it's a bad one imo. Dangerous in that it will 
> lead people to not use PreparedStatement and given it only escapes ', it's 
> not much use. Especially as different dialects escape that in different ways.
> Opening this ticket for discussion. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to