[
https://issues.apache.org/jira/browse/LANG-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Yandell closed LANG-458.
------------------------------
Resolution: Fixed
Refactoring applied. New methods not applied as they don't fit the pattern of
methods in Validate. There's a return type, and an exception is thrown when the
method statement is not true, not when it is true.
> Refactor Validate.java to eliminate code redundancy
> ---------------------------------------------------
>
> Key: LANG-458
> URL: https://issues.apache.org/jira/browse/LANG-458
> Project: Commons Lang
> Issue Type: Improvement
> Environment: software
> Reporter: Viraj Turakhia
> Priority: Minor
> Fix For: 3.0
>
> Attachments: vaidate_diff.txt, validate_test_diff.txt
>
>
> I am using Validate.java since long and find it difficult to use when I just
> want to validate collections or string.
> With current interface, I go like this:
> while(cnt < list.size()) {
> List list1 = list.get(cnt);
> try {
> Validate.notEmpty(list1);
> } catch(IllegalArgumentException e) {
> continue;
> }
> }
> much better approach is:
> while(cnt < list.size()) {
> List list1 = list.get(cnt);
> try {
> if(! Validate.notEmpty(list1)) {
> continue;
> }
> }
> If you all agree with this change, I am willing to submit a patch for this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
