[ 
https://issues.apache.org/jira/browse/JEXL-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730531#action_12730531
 ] 

Henri Biestro edited comment on JEXL-58 at 7/14/09 9:59 AM:
------------------------------------------------------------

Besides {UnifiedJEXL,UnifiedJEXLTest}.java, the patch carries some small 
improvements especially regarding exception reporting & javadoc.

Quick notes for reviewers:
*Debugger.java:
fixed edge case in debug()

*Expression.java / ExpressionImpl.java
evaluate signature modified (does not throw)
cleaned up remnants of pre/post resolvers

*Interpreter.java
simplified import (import org.apache.commons.jexl.parser.*)
handles ArithmeticException (divide by zero)
added registers for JexlEngine.{set,get}Property
simplified constructor to use JexlEngine, JexlContext
exposed {set,get}Silent method

*JexlArithmetic.java
division by zero ignored only if JexlEngine.isSilent()

*JexlEngine.java
improved exception reporting, silent mode logs exceptions as info
ensure derivability (protected fields/methods)
added configurable expression cache
added {set,get}Property methods allowing to set/get properties from any bean 
using an expression

*AithmeticTest.java
added division by zero tests

*Paser.jjt
parsing only throws ParserException
added C style in-line comments (/*...*/)

*Other:
JEXL-32 fixed in 2.0
JEXL-21 wont be fixed but JexlArithmetic can be derived to implement this kind 
of feature
JEXL-35 JexlEngine / JexlArithmetic are the root points of extensibility

      was (Author: henrib):
    Besides {UnifiedEL,UnifiedELTest}.java, the patch carries some small 
improvements especially regarding exception reporting & javadoc.

Quick notes for reviewers:
*Debugger.java:
fixed edge case in debug()

*Expression.java / ExpressionImpl.java
evaluate signature modified (does not throw)
cleaned up remnants of pre/post resolvers

*Interpreter.java
simplified import (import org.apache.commons.jexl.parser.*)
handles ArithmeticException (divide by zero)
added registers for JexlEngine.{set,get}Property
simplified constructor to use JexlEngine, JexlContext
exposed {set,get}Silent method

*JexlArithmetic.java
division by zero ignored only if JexlEngine.isSilent()

*JexlEngine.java
improved exception reporting, silent mode logs exceptions as info
ensure derivability (protected fields/methods)
added configurable expression cache
added {set,get}Property methods allowing to set/get properties from any bean 
using an expression

*AithmeticTest.java
added division by zero tests

*Paser.jjt
parsing only throws ParserException
added C style in-line comments (/*...*/)

*Other:
JEXL-32 fixed in 2.0
JEXL-21 wont be fixed but JexlArithmetic can be derived to implement this kind 
of feature
JEXL-35 JexlEngine / JexlArithmetic are the root points of extensibility
  
> UnifiedJEXL
> -----------
>
>                 Key: JEXL-58
>                 URL: https://issues.apache.org/jira/browse/JEXL-58
>             Project: Commons JEXL
>          Issue Type: New Feature
>            Reporter: Henri Biestro
>             Fix For: 2.0
>
>         Attachments: JEXL-58.patch, JEXL-58.patch
>
>
>  An evaluator similar to the unified EL evaluator used in JSP/JSF based on 
> JEXL.
>  It is intended to be used in configuration modules, XML based frameworks or 
> JSP taglibs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to