[ 
https://issues.apache.org/jira/browse/CODEC-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731705#action_12731705
 ] 

Julius Davies edited comment on CODEC-78 at 7/15/09 2:39 PM:
-------------------------------------------------------------

I think the attached patch brings us up to:

Base64 (100%, 98%)
Base64InputStream (100%, 100%)
Base64OutputStream (100%, 100%)

The remaining 2% in Base64 is quite hard to test:

{code}
Line #703:
if (len > Integer.MAX_VALUE) { throw new IllegalArgumentException(); }

Line #306:
303  try {
304     sep = new String(lineSeparator, "UTF-8");
305  } catch (UnsupportedEncodingException uee) {
306     sep = new String(lineSeparator);
307  }
{code}


      was (Author: juliusdavies):
    I think the attached patch brings us up to:

Base64 (100%, 98%)
Base64InputStream (100%, 100%)
Base64OutputStream (100%, 100%)

The remaining 2% in Base64 is quite hard to test:

Line #703:
if (len > Integer.MAX_VALUE) { throw new IllegalArgumentException(); }


Line #306:
303  try {
304     sep = new String(lineSeparator, "UTF-8");
305  } catch (UnsupportedEncodingException uee) {
306     sep = new String(lineSeparator);
307  }


  
> Base64:  Improve Code Coverage
> ------------------------------
>
>                 Key: CODEC-78
>                 URL: https://issues.apache.org/jira/browse/CODEC-78
>             Project: Commons Codec
>          Issue Type: Test
>    Affects Versions: 1.4
>            Reporter: Julius Davies
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: codec78.patch
>
>
> Base64:  Improve Code Coverage
> As Gary noted:
> On Wed, Jul 15, 2009 at 12:59 PM, Gary Gregory<[email protected]> 
> wrote:
> > Taking a quick look at the Cobertura coverage line/branch reports:
> >
> > Base64InputStream 85%/76%
> > Base64OutputStream 88%/70%
> >
> > Gary

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to