[
https://issues.apache.org/jira/browse/JEXL-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732881#action_12732881
]
Henri Biestro edited comment on JEXL-20 at 7/18/09 7:43 AM:
------------------------------------------------------------
More (tedious :-)) fixes
I've generated the patch from a Mac & applied it on Windows and it does apply
gracefully (luckily).
However:
- almost all files dont end up with "new line", which makes ~30 errors (does
not seem that a generated patch applied can correct those since I know for
certain I added a blank line at the end of each file)
- a bunch of errors are related to @Override that (I believe) are invalid
(since they should imply inheritedDoc somehow) ~40
- @throws for JexlException which are unchecked thus not-reported thus are seen
as errors ~20
There are probably ~10 errors which might be valid but a commit would
tremendously help here.
was (Author: henrib):
More (tedious :-)) fixes
I've generated the patch from a Mac & applied it on Windows and it does apply
gracefully (luckily).
However:
- almost all files dont end up with "new line", which makes ~30 errors (does
not seem that a generated patch applied can correct those since I know for
certain I added a blank line at the end of each file)
- a bunch of errors are related o @Override that (I believe) are invalid
(since they should imply inheritedDoc somehow) ~40
- @throws for JexlException which are unchecked thus not-reported thus are seen
as errors ~20
There are probably ~10 errors which might be valid but a commit would
tremenduously help here.
> Fix checkstyle issues in 1.1
> ----------------------------
>
> Key: JEXL-20
> URL: https://issues.apache.org/jira/browse/JEXL-20
> Project: Commons JEXL
> Issue Type: Task
> Affects Versions: 1.1
> Reporter: Rahul Akolkar
> Fix For: 2.0
>
> Attachments: JEXL-20.patch, JEXL-20.patch, JEXL-20.patch
>
>
> JEXL 1.1 checkstyle is not clean.
> Reporter: Phil Steitz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
