[ 
https://issues.apache.org/jira/browse/JEXL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735252#action_12735252
 ] 

Henri Biestro edited comment on JEXL-35 at 7/25/09 3:44 AM:
------------------------------------------------------------

Added missing 2 *  package.html.

Some files need to be removed (svn del):
src/java/org/apache/commons/jexl/Arithmetic.java
src/java/org/apache/commons/jexl/parser/JEXLNode.java (*)
src/java/org/apache/commons/jexl/util/PropertyExecutor.java
src/java/org/apache/commons/jexl/util/BooleanPropertyExecutor.java
src/java/org/apache/commons/jexl/util/introspection/UberspectLoggable.java
src/java/org/apache/commons/jexl/util/GetExecutor.java

If on windows, you really need to remove it before applying the patch otherwise 
it will just keep using JEXLNode.java for a class named JexlNode...

The patch does not apply cleanly especially UberspectImpl & Introspector.
The "best" approach I've found yet is to force apply updates even if patch 
thinks it may have already been applied.
Then, for each of them, copy/paste the '.rej' content replacing the end of the 
original file with the content at the proper place; a quick regexp replace with 
'^+ ' to get rid of these '+' and it should be ok.

I wish I had a way to generate patches guaranteed to apply (a tool that would 
apply the patch to the original file & if rejects are found, re-create a patch 
for this file that replaces the whole content - delete all original content, 
add all new content - with the new one....)

      was (Author: henrib):
    Added missing 2 *  package.html
  
> Final API requirements
> ----------------------
>
>                 Key: JEXL-35
>                 URL: https://issues.apache.org/jira/browse/JEXL-35
>             Project: Commons JEXL
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: dion gillard
>             Fix For: 2.0
>
>         Attachments: JEXL-35.patch, JEXL-35.patch, JEXL-35.patch
>
>
> Which classes should be public?
> Is the package structure reasonable? 
> Are classes in the right packages?
> Is it easily extensible?
> ...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to