[
https://issues.apache.org/jira/browse/POOL-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744697#action_12744697
]
Sandy McArthur commented on POOL-148:
-------------------------------------
Once Java 1.4 is a minimum requirement this is basically a good idea. I gotta
disagree with the NoSuchElementException to Exception change but taking
advantage of exception chaining is good.
> borrowObject should return the exception thrown by validateObject when
> throwing an Exception to let Exceptions be handled at a higher level
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: POOL-148
> URL: https://issues.apache.org/jira/browse/POOL-148
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.5.2
> Environment: All
> Reporter: Monsieur EDI
>
> public Object borrowObject() throws Exception {
> ...
> try {
> ...
> if(newlyCreated) {
> throw new NoSuchElementException("Could not create a
> validated object, cause: " + e.getMessage());
> }
> SHOULD BE CHANGED TO :
> if(newlyCreated) {
> throw new Exception("Could not create a validated
> object", e);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
