[
https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745720#action_12745720
]
Rahul Akolkar commented on JEXL-85:
-----------------------------------
Given the size of this patch and an upcoming vacation, I won't be able to look
at this for a couple of weeks atleast. Hopefully someone will get here sooner.
I agree with sebb that whoever examines and applies the patch -- could be you,
Henri, once your account is set up -- should apply it in multiple commits.
Ideally, one commit for each functional change (but given where we are, as
close as possible). Also, any non-functional changes such as moving grammar
statements to match some logical grouping should be clearly separated from
functional changes in terms of SVN commit history. This is time-consuming now,
but is good for the long term health of the code so its worth spending time on,
IMO. Finally, once your account is setup, it'll get much easier to do all this
ofcourse, so perhaps this is the last patch we'll have to wrestle with a bit :-)
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the
> "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real
> nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map
> literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
