[ 
https://issues.apache.org/jira/browse/DBCP-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754653#action_12754653
 ] 

Phil Steitz commented on DBCP-300:
----------------------------------

In this case, the locking is in DBCP itself:

 public Connection getConnection() throws SQLException {
        return createDataSource().getConnection();
    }

and createDataSource is synchronized.


> remove synchronize access of createDataSource
> ---------------------------------------------
>
>                 Key: DBCP-300
>                 URL: https://issues.apache.org/jira/browse/DBCP-300
>             Project: Commons Dbcp
>          Issue Type: Improvement
>    Affects Versions: 1.2.2
>         Environment: RHEL, jdk1.5.0_12, commons-dbcp 1.2.2
>            Reporter: Nikhil Singh
>
> For JDK1.5 onwards we can make the DataSource volatile and start using 
> "double checked locking" idiom. In my performance testing I have already 
> started seeing wait time on this lock. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to