garydgregory edited a comment on pull request #168: URL: https://github.com/apache/commons-vfs/pull/168#issuecomment-813031240
Hi @XenoAmess Thank you for the update. I'll take a look but you'll want to redo these tests to use JUnit's parameterized test feature instead of looping over `TEST_FILE_PATHS`. This will avoid the loops inside the test methods AND will insure that ALL test variations are run. Since you also have a test that loops on all Characters, you might want to either: Create a new test class, or, parameterize only the test methods instead of the whole class. Looking ahead to JUnit 5, it would be best to parameterize the test methods and not the class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
