[
https://issues.apache.org/jira/browse/TEXT-200?focusedWorklogId=584811&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584811
]
ASF GitHub Bot logged work on TEXT-200:
---------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/21 20:26
Start Date: 18/Apr/21 20:26
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #222:
URL: https://github.com/apache/commons-text/pull/222#discussion_r615449277
##########
File path:
src/main/java/org/apache/commons/text/translate/UnicodeUnpairedSurrogateRemover.java
##########
@@ -31,12 +31,9 @@
*/
@Override
public boolean translate(final int codepoint, final Writer writer) throws
IOException {
- if (codepoint >= Character.MIN_SURROGATE && codepoint <=
Character.MAX_SURROGATE) {
- // It's a surrogate. Write nothing and say we've translated.
- return true;
- }
+ // It's a surrogate. Write nothing and say we've translated.
Review comment:
@arturobernalg I think this comment here doesn't relate to the single
return statement now (it is, and it is not, true and false now).
Maybe change it to `// If true, it is a surrogate. Write nothing and say
we've translated. Otherwise return false, and don't translate it.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 584811)
Time Spent: 0.5h (was: 20m)
> Simplify statements
> -------------------
>
> Key: TEXT-200
> URL: https://issues.apache.org/jira/browse/TEXT-200
> Project: Commons Text
> Issue Type: Sub-task
> Reporter: Arturo Bernal
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
