[
https://issues.apache.org/jira/browse/IMAGING-291?focusedWorklogId=586921&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586921
]
ASF GitHub Bot logged work on IMAGING-291:
------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/21 21:47
Start Date: 21/Apr/21 21:47
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #135:
URL: https://github.com/apache/commons-imaging/pull/135#discussion_r617902277
##########
File path:
src/main/java/org/apache/commons/imaging/palette/ColorSpaceSubset.java
##########
@@ -24,8 +24,8 @@
private static final Logger LOGGER =
Logger.getLogger(ColorSpaceSubset.class.getName());
- final int[] mins;
- final int[] maxs;
+ final int[] min;
+ final int[] max;
Review comment:
I think these were supposed to be arrays with minimums and maximums.
It's common to use the "maximums" or "minimums" as the "locals minimums" for
example. So `mins` is a better variable name IMO, so that without seeing the
type you know it's an array (especially given it's in a class related to color
space).
##########
File path:
src/main/java/org/apache/commons/imaging/formats/tiff/constants/MicrosoftHdPhotoTagConstants.java
##########
@@ -152,17 +152,17 @@
public static final BinaryConstant
PIXEL_FORMAT_VALUE_32_BIT_GRAY_FIXED_POINT =
createMicrosoftHdPhotoGuidEndingWith((byte) 0x3f);
- public static final TagInfoLong EXIF_TAG_TRANSFOMATION = new TagInfoLong(
- "Transfomation", 0xbc02,
+ public static final TagInfoLong EXIF_TAG_TRANSFORMATION = new TagInfoLong(
+ "Transformation", 0xbc02,
TiffDirectoryType.EXIF_DIRECTORY_UNKNOWN);
- public static final int TRANSFOMATION_VALUE_HORIZONTAL_NORMAL = 0;
- public static final int TRANSFOMATION_VALUE_MIRROR_VERTICAL = 1;
- public static final int TRANSFOMATION_VALUE_MIRROR_HORIZONTAL = 2;
- public static final int TRANSFOMATION_VALUE_ROTATE_180 = 3;
- public static final int TRANSFOMATION_VALUE_ROTATE_90_CW = 4;
- public static final int
TRANSFOMATION_VALUE_MIRROR_HORIZONTAL_AND_ROTATE_90_CW = 5;
- public static final int
TRANSFOMATION_VALUE_MIRROR_HORIZONTAL_AND_ROTATE_270_CW = 6;
- public static final int TRANSFOMATION_VALUE_ROTATE_270_CW = 7;
+ public static final int TRANSFORMATION_VALUE_HORIZONTAL_NORMAL = 0;
+ public static final int TRANSFORMATION_VALUE_MIRROR_VERTICAL = 1;
+ public static final int TRANSFORMATION_VALUE_MIRROR_HORIZONTAL = 2;
+ public static final int TRANSFORMATION_VALUE_ROTATE_180 = 3;
+ public static final int TRANSFORMATION_VALUE_ROTATE_90_CW = 4;
+ public static final int
TRANSFORMATION_VALUE_MIRROR_HORIZONTAL_AND_ROTATE_90_CW = 5;
+ public static final int
TRANSFORMATION_VALUE_MIRROR_HORIZONTAL_AND_ROTATE_270_CW = 6;
+ public static final int TRANSFORMATION_VALUE_ROTATE_270_CW = 7;
Review comment:
Ouch! Good catch! Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 586921)
Time Spent: 0.5h (was: 20m)
> Fix Typo
> ---------
>
> Key: IMAGING-291
> URL: https://issues.apache.org/jira/browse/IMAGING-291
> Project: Commons Imaging
> Issue Type: Sub-task
> Reporter: Arturo Bernal
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Fix typo in javadoc and variables name
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
