[ 
https://issues.apache.org/jira/browse/RNG-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332004#comment-17332004
 ] 

Gilles Sadowski commented on RNG-132:
-------------------------------------

bq. As a work-in-progress does it matter? [...]

No, but I thought that from a user's POV, it was better to not have these 
specific samplers bundled with the core samplers (i.e. distribution and common 
utilities).

bq. [...] without use of objects from [Geometry]

Can we guarantee that no future class of the same kind will never need to 
depend on [Geometry]?

bq. Any use of [Geometry] would sit on top of this by offering to sample from 
geometry objects.

Isn't [Geometry] a better for home for an extension that combines [Geometry] 
objects with implementations from the [RNG] "shape" package/module?


> Package rng.sampling.shape for sampling coordinates from shapes
> ---------------------------------------------------------------
>
>                 Key: RNG-132
>                 URL: https://issues.apache.org/jira/browse/RNG-132
>             Project: Commons RNG
>          Issue Type: Task
>          Components: sampling
>    Affects Versions: 1.4
>            Reporter: Alex Herbert
>            Assignee: Alex Herbert
>            Priority: Major
>
> Create a {{rng.sampling.shape}} package in the sampling module to contain 
> work-in-progress samplers for shapes.
>  * UnitSphereSampler (N-surface) [1]
>  * UnitBallSampler (N-volume)
>  * UnitSimplexSampler (N-surface)
>  * LineSampler (N-dimension points on a line segment or polyline)
>  * TriangleSampler (N-dimension points within a triangle in a 2D plane)
>  * TetrahedronSampler (3D points inside a tetrahedron)
>  * SurfaceSampler (ND points on a triangulated surface) [2]
>  * VolumeSampler (3D points inside a volume composed of tetrahedrons)
>  * UnitCubeSampler (N-volume)
> [1] The UnitSphereSampler can be deprecated and a new version created to use 
> a factory method to create the sampler (allowing optimisation for low 
> dimensions).
> [2] The SurfaceSampler would be a composite sampler. For sampling a surface 
> the TriangleSampler can be combined with the 
> AliasMethodSamplerDiscreteSampler. The surface should be triangulated. The 
> area of each triangle is used to create a distribution of which triangle to 
> pick using the alias method. A sample is then taken from the chosen triangle.
> Shape geometry will not be validated beyond basic testing for non-finite 
> values of input coordinates. Validation of shapes could potentially be done 
> by creating a {{commons-geometry-sampling}} module in the commons geometry 
> project.
>   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to