[
https://issues.apache.org/jira/browse/FILEUPLOAD-326?focusedWorklogId=591859&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591859
]
ASF GitHub Bot logged work on FILEUPLOAD-326:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/21 11:32
Start Date: 01/May/21 11:32
Worklog Time Spent: 10m
Work Description: arturobernalg commented on pull request #77:
URL: https://github.com/apache/commons-fileupload/pull/77#issuecomment-830617832
> I am mostly with you, except for changing
>
> ```
> assertFalse(condition);
> ```
>
> to
>
> ```
> assertTrue(!condition);
> ```
>
> Would you, please, change that?
I've reverted the change. Even though IMO it's more ease read
`assertFalse (conditions)` than `assertTrue(!conditions);` avoing to check
two conditions. The inner conditions with (!) and the Assert itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 591859)
Time Spent: 50m (was: 40m)
> Simplify Assertion
> ------------------
>
> Key: FILEUPLOAD-326
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-326
> Project: Commons FileUpload
> Issue Type: Sub-task
> Reporter: Arturo Bernal
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
