Arturo Bernal created FILEUPLOAD-331:
----------------------------------------

             Summary: Solve warnings / error checkstyle
                 Key: FILEUPLOAD-331
                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-331
             Project: Commons FileUpload
          Issue Type: Bug
            Reporter: Arturo Bernal


The idea it's to resolve all the warning and error of the checkstyle 

 

 
 * Checkstyle found 40 item(s) in 17 file(s)
 * Base64Decoder.java : 1 item(s)
 * 'byte' is followed by whitespace. (107:20) [NoWhitespaceAfter]
 * DiskFileItem.java : 2 item(s)
 * Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. (1:0) 
[NewlineAtEndOfFile]
 * Avoid inline conditionals. (308:42) [AvoidInlineConditionals]
 * FileItemIterator.java : 2 item(s)
 * Expected line ending for file is LF(\n), but CRLF(\r\n) is detected. (1:0) 
[NewlineAtEndOfFile]
 * File contains tab characters (this is the first instance). (30:1) 
[FileTabCharacter]
 * FileItemIteratorImpl.java : 6 item(s)
 * File does not end with a newline. (1:0) [NewlineAtEndOfFile]
 * File contains tab characters (this is the first instance). (47:1) 
[FileTabCharacter]
 * Missing a Javadoc comment. (47:9) [JavadocVariable]
 * Missing a Javadoc comment. (48:9) [JavadocVariable]
 * Missing a Javadoc comment. (49:9) [JavadocVariable]
 * Line is longer than 120 characters (found 167). (339:0) [LineLength]
 * FileItemStreamImpl.java : 4 item(s)
 * File does not end with a newline. (1:0) [NewlineAtEndOfFile]
 * File contains tab characters (this is the first instance). (38:1) 
[FileTabCharacter]
 * Missing a Javadoc comment. (38:9) [JavadocVariable]
 * Variable 'name' must be private and have accessor methods. (53:18) 
[VisibilityModifier]
 * FileSizeLimitExceededException.java : 1 item(s)
 * File does not end with a newline. (1:0) [NewlineAtEndOfFile]
 * FileUploadBase.java : 1 item(s)
 * Line is longer than 120 characters (found 133). (330:0) [LineLength]
 * FileUploadIOException.java : 1 item(s)
 * File does not end with a newline. (1:0) [NewlineAtEndOfFile]
 * IOFileUploadException.java : 1 item(s)
 * File does not end with a newline. (1:0) [NewlineAtEndOfFile]
 * InvalidContentTypeException.java : 1 item(s)
 * File does not end with a newline. (1:0) [NewlineAtEndOfFile]
 * ParameterParser.java : 1 item(s)
 * Avoid inline conditionals. (319:80) [AvoidInlineConditionals]
 * ParseException.java : 1 item(s)
 * Redundant 'public' modifier. (34:5) [RedundantModifier]
 * RFC2231Utility.java : 12 item(s)
 * Line is longer than 120 characters (found 148). (25:0) [LineLength]
 * Utility classes should not have a public or default constructor. (32:1) 
[HideUtilityClassConstructor]
 * Missing a Javadoc comment. (34:5) [JavadocVariable]
 * Missing a Javadoc comment. (36:5) [JavadocVariable]
 * '0x80' is a magic number. (36:55) [MagicNumber]
 * First sentence should end with a period. (46:0) [JavadocStyle]
 * First sentence should end with a period. (59:0) [JavadocStyle]
 * Line is longer than 120 characters (found 122). (86:0) [LineLength]
 * First sentence should end with a period. (106:0) [JavadocStyle]
 * '0x7f' is a magic number. (119:63) [MagicNumber]
 * '0x7f' is a magic number. (120:63) [MagicNumber]
 * '4' is a magic number. (121:34) [MagicNumber]
 * SizeException.java : 2 item(s)
 * File does not end with a newline. (1:0) [NewlineAtEndOfFile]
 * Missing package-info.java file. (1:0) [JavadocPackage]
 * SizeLimitExceededException.java : 1 item(s)
 * File does not end with a newline. (1:0) [NewlineAtEndOfFile]
 * Streams.java : 2 item(s)
 * Line is longer than 120 characters (found 124). (65:0) [LineLength]
 * File contains tab characters (this is the first instance). (148:5) 
[FileTabCharacter]
 * UnknownSizeException.java : 1 item(s)
 * File does not end with a newline. (1:0) [NewlineAtEndOfFile]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to