[
https://issues.apache.org/jira/browse/DIGESTER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pieter updated DIGESTER-136:
----------------------------
Attachment: DigesterRuleParser.patch
Patch file with suggested modifications
> Reusability of DigesterRuleParser
> ---------------------------------
>
> Key: DIGESTER-136
> URL: https://issues.apache.org/jira/browse/DIGESTER-136
> Project: Commons Digester
> Issue Type: Bug
> Affects Versions: 2.0
> Reporter: Pieter
> Attachments: DigesterRuleParser.patch
>
>
> I'm extending DigesterRuleParser with my own rules and I am using included
> files with my own rules. DigesterRuleParser contains private classes which
> make reuse difficult. I added a patch trying to solve this (at least it
> solves my problems in my project).
> - The docs explain that my own rules can be added by overriding
> addRuleInstances. Doing so I want to be able to use the same construct as in
> the base class. So I want to be able to add the PatternRule from the base
> class. Therefore I made PatternRule protected. Copy pasting PatternRule to
> the sub class is no solution.
> - While I made PatternRule protected, I did the same for IncludeRule, to keep
> everything consequent. For the same reason I also made
> BeanPropertySetterRuleFactory protected.
> - IncludeRule parses the included file with the base DigesterRuleParser
> instead of the sub class. As a result my own rules are not recognized in
> included files. I have modified IncludeRule to fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
