kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841605341


   @gwlucastrig 
   
   >great suggestion from @gwlucastrig : "use one call for setSubImage, rather 
than 4 separate calls for setSubImageX, Y, Width, Height."
   
   I started making this change in the `TiffImagingParameter`. First the 
`public void setSubImage(Integer width, Integer height, Integer x, Integer y)`. 
All good so far.
   
   But when I finished and started adding the getter, I was thinking in Python 
or JS, and wanted to return all the 4 parameters at once 
:disappointed_relieved: Then I realized I would have to create another class to 
return the 4 parameters… do you have any suggestion for the getter of the 
subimage in the tiff imaging parameter class?
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to