[
https://issues.apache.org/jira/browse/COMPRESS-578?focusedWorklogId=600846&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600846
]
ASF GitHub Bot logged work on COMPRESS-578:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/21 13:43
Start Date: 22/May/21 13:43
Worklog Time Spent: 10m
Work Description: bodewig commented on a change in pull request #194:
URL: https://github.com/apache/commons-compress/pull/194#discussion_r637405636
##########
File path:
src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java
##########
@@ -937,7 +936,7 @@ private void sanityCheckSubStreamsInfo(final ByteBuffer
header, final ArchiveSta
for (int i = 0; i < stats.numberOfFolders; i++) {
numUnpackSubStreamsPerFolder.add(assertFitsIntoNonNegativeInt("numStreams",
readUint64(header)));
}
- stats.numberOfUnpackSubStreams =
numUnpackSubStreamsPerFolder.stream().collect(Collectors.summingLong(Integer::longValue));
+ stats.numberOfUnpackSubStreams =
numUnpackSubStreamsPerFolder.stream().mapToLong(Integer::longValue).sum();
Review comment:
Why do you think the current alternative would require temporary
objects? The summingLong collector is working on primitive longs just like
sum() is, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 600846)
Time Spent: 50m (was: 40m)
> Java 8 improvements
> -------------------
>
> Key: COMPRESS-578
> URL: https://issues.apache.org/jira/browse/COMPRESS-578
> Project: Commons Compress
> Issue Type: Sub-task
> Reporter: Arturo Bernal
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> * Use lambda alternative
> * Use reference
> * Replace Loop with Collection.removeIf()
> * Use mapToLong().sum()'
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
