HelderMagalhaes commented on pull request #199:
URL: https://github.com/apache/commons-compress/pull/199#issuecomment-846991690


   > I'm a little confused about your PR #197, #198 and #199. They look pretty 
similar. What's the difference? It's appreciated if you can close the PRs you 
don't want to push.
   
   I did want to push but in different pull requests:
   * PR 197 was regarding the "whitespace improvement" which had been submitted 
to PR 192 but didn't get through due to being mixed with other changed.
   * PR 198 was regarding the "site nits", which are also included here
   * The remaining part (the initial goal for this PR) are few typos noticed.
   
   The idea was to keep this one, as it gathers all changes away, in the hope 
that mixing slightly different things, particularly whitespace ("If you feel 
the source code should be reformatted create a separate PR for this change 
first.", as also hinted by @bodewig in already referred PR 192) isn't a 
problem. Otherwise I'll also close this PR and try resubmit all three. What do 
you think?
   
   
   > BTW : there're so many commits in your PR. Could you squash them?
   
   If there's a need to resubmit the PR I'll take that into consideration. 
Thanks for the feedback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to