[
https://issues.apache.org/jira/browse/MATH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350533#comment-17350533
]
Samy Badjoudj commented on MATH-1517:
-------------------------------------
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried to break those:
{color:#808080}<!-- Modules that do not depend on "legacy" codes.
-->{color}{color:#e8bf6a}
{color}{color:#e8bf6a}<module>{color}commons-math-utils{color:#e8bf6a}</module>
{color}{color:#e8bf6a}<module>{color}commons-math-linear{color:#e8bf6a}</module>
{color}{color:#e8bf6a}<module>{color}commons-math-clustering{color:#e8bf6a}</module>
{color}{color:#e8bf6a}<module>{color}commons-math-stat{color:#e8bf6a}</module>
{color}{color:#e8bf6a}<module>{color}commons-math-analysis{color:#e8bf6a}</module>{color}
Steps done so far to break the monolithic legacy project:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected:<NaN> but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected:<NaN> but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected:<NaN> but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected:<NaN> but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected<org.apach..._
_[INFO]_
_[ERROR] Tests run: 954, Failures: 4, Errors: 1, Skipped: 27_
* commons-math-clustering All tests pass
* commons-math-stat All tests pass
* commons-math-analysis All tests pass
Need to fix, would be good to split the work via Jira issues :):
* Fix tests mentioned above
* Duplication of some test classes (test class utils)
* CorrelatedRandomVectorGeneratorTest -> commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
> "Cluster" leaks internal data
> -----------------------------
>
> Key: MATH-1517
> URL: https://issues.apache.org/jira/browse/MATH-1517
> Project: Commons Math
> Issue Type: Bug
> Reporter: Gilles Sadowski
> Priority: Major
> Fix For: 4.0
>
> Attachments: MATH-1517_cluster_points_leak
>
>
> Method {{getPoints()}} returns a reference to a mutable instance field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
