[ 
https://issues.apache.org/jira/browse/RNG-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351360#comment-17351360
 ] 

Alex Herbert commented on RNG-137:
----------------------------------

Into {{rng.sampling.distributions}} package?

It has a lot of different samplers depending on the parameters. This would be a 
case for refactoring to a factory constructor that picked the correct sampler:
{code:java}
public static StableRandomGenerator of(double alpha, double beta, 
UniformRandomProvider rng);
{code}
One case seems to be a NormalisedGaussianSampler. So the factory constructor 
could return a SharedStateContinuousSampler instead. I would have to read more 
about it and view the current test cases in CM. I'll assign this to me and look 
into the port.

> Move class from "Commons Math"
> ------------------------------
>
>                 Key: RNG-137
>                 URL: https://issues.apache.org/jira/browse/RNG-137
>             Project: Commons RNG
>          Issue Type: Task
>          Components: sampling
>            Reporter: Gilles Sadowski
>            Priority: Trivial
>              Labels: commons-math, port
>             Fix For: 1.4
>
>
> Shouldn't CM's class 
> [{{StableRandomGenerator}}|https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=src/main/java/org/apache/commons/math4/random/StableRandomGenerator.java;h=f3a851b9b16c47546cac8371e272dbf59a909c09;hb=HEAD]
>  be moved to the{{commons-rng-sampling}} module?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to