[
https://issues.apache.org/jira/browse/MATH-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352553#comment-17352553
]
Gilles Sadowski commented on MATH-1536:
---------------------------------------
Most of the unit tests listed in the issue description have been reverted to
use a random seed, and behave reasonably fine.
With 4 allowed retries, a test that still (too) often fails is
[{{GaussianRandomGeneratorTest}}|https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/random/GaussianRandomGeneratorTest.java;h=f31a8fab6f1d493914807dfb22854f5d5b3fd3af;hb=refs/heads/modularized_master].
We can of course perform the same analysis you did above; however, this class
is now just a wrapper for sampling code implemented (and tested) in "Commons
RNG"; hence I'd just remove the unit test. WDYT?
I'd also remove the {{GaussianRandomGenerator}} class altogether but it's
unclear to me whether the
[{{NormalizedRandomGenerator}}|https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/random/NormalizedRandomGenerator.java;h=e41a008c44fd33da08d63645895d91b6aa76b437;hb=refs/heads/modularized_master]
can be deleted. [For sure, its contract is neither checked nor enforced; so it
could be sufficient that the required properties (mean 0, sigma 1) be
documented at the appropriate places.]
> Sensitivity to RNG (unit tests)
> -------------------------------
>
> Key: MATH-1536
> URL: https://issues.apache.org/jira/browse/MATH-1536
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles Sadowski
> Priority: Major
> Labels: rng, unit-test
> Fix For: 4.0
>
>
> Several unit tests fail when upgrading to version 1.3 of "Commons RNG":
> {noformat}
> [ERROR] Failures:
> [ERROR] LogitTest.testDerivativesWithInverseFunction:195 maxOrder = 2
> expected:<0.0> but was:<1.0658141036401503E-14>
> [ERROR] EnumeratedIntegerDistributionTest.testMath1533:196
> [ERROR] EnumeratedIntegerDistributionTest.testSample:174 expected:<7.84>
> but was:<7.857073891264003>
> [ERROR] MiniBatchKMeansClustererTest.testCompareToKMeans:86 Different score
> ratio 46.645378%!, diff points ratio: 34.716981%
> [ERROR] CalinskiHarabaszTest.test_compare_to_skLearn:102
> expected:<597.7763150683217> but was:<559.2829020672648>
> [ERROR] MultiStartMultivariateOptimizerTest.testCircleFitting:76
> expected:<69.9597> but was:<69.96228624385736>
> [ERROR] MultiStartMultivariateOptimizerTest.testRosenbrock:114 numEval=873
> [ERROR] GaussianRandomGeneratorTest.testMeanAndStandardDeviation:37
> expected:<1.0> but was:<0.9715310171501561>
> [ERROR] NaturalRankingTest.testNaNsFixedTiesRandom:227 Array comparison
> failure
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
