[GitHub] [commons-lang] arturobernalg commented on a change in pull request #733: Fixed NPE getting Stack Trace if Throwable is null

Mon, 31 May 2021 06:20:46 -0700 


arturobernalg commented on a change in pull request #733:
URL: https://github.com/apache/commons-lang/pull/733#discussion_r642484571



##########
File path: 
src/test/java/org/apache/commons/lang3/exception/ContextedExceptionTest.java
##########
@@ -48,6 +48,11 @@ public void testContextedException() {
         assertTrue(StringUtils.isEmpty(message));
     }
 
+    @Test
+    public void testNullException() {
+        assertTrue(StringUtils.isEmpty(ExceptionUtils.getStackTrace(null)));

Review comment:
       HI @garydgregory 
   SomeThins like --> `assertNotNull(ExceptionUtils.getStackTrace(null));` ??
   TY




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to