[
https://issues.apache.org/jira/browse/DBCP-576?focusedWorklogId=604164&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-604164
]
ASF GitHub Bot logged work on DBCP-576:
---------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/21 14:49
Start Date: 31/May/21 14:49
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #99:
URL: https://github.com/apache/commons-dbcp/pull/99#discussion_r642541370
##########
File path:
src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSource.java
##########
@@ -198,9 +198,8 @@ public void testManagedConnectionEqualsSameDelegate()
throws Exception {
@Test
public void testManagedConnectionEqualsReflexive() throws Exception {
final Connection con = ds.getConnection();
- final Connection con2 = con;
Review comment:
Don't change there I think. See the title of the method. This makes it
obvious.
##########
File path: src/test/java/org/apache/commons/dbcp2/TestPoolingDataSource.java
##########
@@ -101,9 +101,8 @@ public void
testPoolGuardConnectionWrapperEqualsSameDelegate() throws Exception
public void testPoolGuardConnectionWrapperEqualsReflexive()
throws Exception {
final Connection con = ds.getConnection();
- final Connection con2 = con;
Review comment:
Don't change there I think. See the title of the method. This makes it
obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 604164)
Time Spent: 20m (was: 10m)
> Simplify and inline variables
> -----------------------------
>
> Key: DBCP-576
> URL: https://issues.apache.org/jira/browse/DBCP-576
> Project: Commons DBCP
> Issue Type: Sub-task
> Reporter: Arturo Bernal
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
