[
https://issues.apache.org/jira/browse/DBCP-573?focusedWorklogId=604168&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-604168
]
ASF GitHub Bot logged work on DBCP-573:
---------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/21 14:52
Start Date: 31/May/21 14:52
Worklog Time Spent: 10m
Work Description: reda-alaoui commented on pull request #93:
URL: https://github.com/apache/commons-dbcp/pull/93#issuecomment-851540837
@garydgregory conflicts resolved :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 604168)
Time Spent: 1h 10m (was: 1h)
> DataSource implementations do not implement Wrapper interface correctly
> -----------------------------------------------------------------------
>
> Key: DBCP-573
> URL: https://issues.apache.org/jira/browse/DBCP-573
> Project: Commons DBCP
> Issue Type: Bug
> Affects Versions: 2.8.0
> Reporter: Réda Housni Alaoui
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Let's take {{BasicDataSource}} as an example. Its code is currently:
> {code:java}
> @Override
> public boolean isWrapperFor(final Class<?> iface) throws SQLException {
> return false;
> }
> @Override
> public <T> T unwrap(final Class<T> iface) throws SQLException {
> throw new SQLException("BasicDataSource is not a wrapper.");
> }{code}
> This breaks consumers relying on Wrapper being correctly implemented.
> The DataSource should at least check if *this* is an instance of iface and
> return it from {{unwrap}} if it is.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
