garydgregory commented on a change in pull request #99:
URL: https://github.com/apache/commons-dbcp/pull/99#discussion_r642586088



##########
File path: 
src/test/java/org/apache/commons/dbcp2/datasources/TestSharedPoolDataSource.java
##########
@@ -556,7 +554,7 @@ private void doTestPoolCallableStatements(final 
PrepareCallCallback callBack)
         conn.close();
         conn = null;
 
-        conn = myDs.getConnection();
+        conn = ((DataSource) spDs).getConnection();

Review comment:
       This is not clearer than what was before. I would not do this.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to