[
https://issues.apache.org/jira/browse/DBCP-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Steitz resolved DBCP-289.
------------------------------
Resolution: Fixed
Modified version of the patch applied in 829623. Changes to the patch:
1) Made getter/setter synchronized and field private.
2) Setter sets xads classname field
3) class loading and creation of instance with xads classname are only done if
the xa datasource instance has not been set
Thanks for the patch!
> Allow client to set a XADatasource instance instead of only its classname in
> BasicManagedDataSource
> ---------------------------------------------------------------------------------------------------
>
> Key: DBCP-289
> URL: https://issues.apache.org/jira/browse/DBCP-289
> Project: Commons Dbcp
> Issue Type: Improvement
> Affects Versions: 1.2.2
> Reporter: Marc Kannegießer
> Priority: Minor
> Fix For: 1.3
>
> Attachments: set_xadatasource_instance.patch
>
>
> {{BasicManagedDataSource}} currently allows to set the classname of an
> {{XADatasource}} to create XA-enabled connections.
> If done so the datasource is created using the Reflection-API.
> I think in most cases this is not enough, since DataSources usually need some
> kind of configuration. In my case this would be the connection-url to the
> database (I use {{MysqlXADatasource}} which wants its {{setUrl(url)}} method
> called).
> For this reason i think it would be useful to let the client set the
> {{XADataSource}} instance instead of its classname (optional). The same is
> done now with the TransactionManager-Implementation.
> For this reason i'd suggest a getter and setter as well as a new member
> xaDataSourceInstance as an alternative option to the classname.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
