darkma773r commented on a change in pull request #92:
URL: https://github.com/apache/commons-numbers/pull/92#discussion_r646200076
##########
File path:
commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/ExtendedPrecisionTest.java
##########
@@ -102,6 +102,23 @@ void testSubNormalSplit() {
final double lo2 = a - hi2;
Assertions.assertEquals(a, hi2);
Assertions.assertEquals(0, lo2);
+
+
Assertions.assertTrue(Math.abs(hi2) > Math.abs(lo2));
}
+
+ @Test
+ void testSquareLowUnscaled() {
+ assertSquareLowUnscaled(0.0, 1.0);
+ assertSquareLowUnscaled(0.0, -1.0);
+ assertSquareLowUnscaled(-1.4293872661474477E-16, Math.PI);
Review comment:
That sounds good but the expected value computed with `BigDecimal` is
`-8.79470486217151E-16` whereas the `ExtendedPrecision` result is
`-1.4293872661474477E-16`. Is this simply a limitation of the algorithm or is
this a bug in our implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
