[ 
https://issues.apache.org/jira/browse/MATH-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369581#comment-17369581
 ] 

Alex Herbert commented on MATH-1576:
------------------------------------

Fixed a lot of checkstyle in commits:

f8741d3ab644b940ce309bc2f68796ff415886d5

4ec8e6dfe6f5da30c50973eb971af59910635328

 

The following modules have been commented out:

ParameterNumber - 50 errors
MethodParamPad - 94 errors
NoWhitespaceAfter - 3949 errors
NoWhitespaceBefore - 1605 errors
OperatorWrap - 54 errors
ParenPad - 884 errors
WhitespaceAfter - 7543 errors
WhitespaceAround - 2198 errors
HiddenField - 64 errors
ArrayTypeStyle - 197 errors
Indentation - 7293 errors

 

The indentation and whitespace seems to be a big problem. I may look at this 
another time. For now checkstyle is at least working and any code lifted from 
the legacy module will have to be corrected for these last issues.

 

> Reinstate "checkstyle"
> ----------------------
>
>                 Key: MATH-1576
>                 URL: https://issues.apache.org/jira/browse/MATH-1576
>             Project: Commons Math
>          Issue Type: Sub-task
>            Reporter: Gilles Sadowski
>            Priority: Critical
>              Labels: checkstyle
>             Fix For: 4.0
>
>
> Modularization configuration was copied from Commons Numbers that used a 
> newer Checkstyle with a different syntax. The checks trigger more than 31000 
> errors in Commons Math; so all checks have been disabled. :(
> The syntax of the configuration that worked before modularization should be 
> adapted to the new syntax...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to